Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [trivial PATCH] module.h: Remove unnecessary semicolon | Date | Fri, 08 Nov 2013 11:56:12 +1030 |
| |
Joe Perches <joe@perches.com> writes: > On Fri, 2013-11-08 at 09:41 +1030, Rusty Russell wrote: >> Joe Perches <joe@perches.com> writes: >> > That's a trust issue. >> > I've done it. It isn't necessary. >> >> WTF? Now you just said it's not necessary, I *know* I can't trust you. > > "It" in this case is the grep that I did > prior to sending the patch.
Hi Joe,
Apologies for my off tone. But I think we got tangled somewhere?
You said "It isn't necessary".
You maintain that grepping the source to find out if you'd broken something "isn't necessary"?
git history shows me you've done lots of these cleanups. I'm pretty sure that's not what you meant.
But as maintainer, it's annoying that I had to check myself. I don't have personal experience in how diligent you are. If you'd just mentioned it, it would have saved me a few minutes and streamlined my workflow immensely.
Providing assurance makes me a happy maintainer. So I modified it because it sets a clear example for others.
I hope that clarifies, Rusty.
| |