Messages in this thread | | | Date | Thu, 07 Nov 2013 19:07:27 -0500 (EST) | Subject | Re: [PATCH] net: x86: bpf: don't forget to free sk_filter (v2) | From | David Miller <> |
| |
From: Andrey Vagin <avagin@openvz.org> Date: Thu, 7 Nov 2013 08:35:12 +0400
> sk_filter isn't freed if bpf_func is equal to sk_run_filter. > > This memory leak was introduced by v3.12-rc3-224-gd45ed4a4 > "net: fix unsafe set_memory_rw from softirq". > > Before this patch sk_filter was freed in sk_filter_release_rcu, > now it should be freed in bpf_jit_free. > > Here is output of kmemleak: ... > v2: add extra { } after else > > Fixes: d45ed4a4e33a ("net: fix unsafe set_memory_rw from softirq") > Acked-by: Daniel Borkmann <dborkman@redhat.com> > Cc: Alexei Starovoitov <ast@plumgrid.com> > Cc: Eric Dumazet <edumazet@google.com> > Cc: "David S. Miller" <davem@davemloft.net> > Signed-off-by: Andrey Vagin <avagin@openvz.org>
Applied and queued up for -stable, thanks!
| |