Messages in this thread Patch in this message | | | Date | Thu, 7 Nov 2013 18:58:35 -0500 | From | Greg Price <> | Subject | [PATCH 03/11] random: fix description of get_random_bytes |
| |
After this remark was written, commit d2e7c96af added a use of arch_get_random_long() inside the get_random_bytes codepath. The main point stands, but it needs to be reworded.
Cc: "Theodore Ts'o" <tytso@mit.edu> Signed-off-by: Greg Price <price@mit.edu> --- drivers/char/random.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/char/random.c b/drivers/char/random.c index a89ba74..d1466c9 100644 --- a/drivers/char/random.c +++ b/drivers/char/random.c @@ -1048,8 +1048,9 @@ static ssize_t extract_entropy_user(struct entropy_store *r, void __user *buf, /* * This function is the exported kernel interface. It returns some * number of good random numbers, suitable for key generation, seeding - * TCP sequence numbers, etc. It does not use the hw random number - * generator, if available; use get_random_bytes_arch() for that. + * TCP sequence numbers, etc. It does not rely on the hardware random + * number generator. For random bytes direct from the hardware RNG + * (when available), use get_random_bytes_arch(). */ void get_random_bytes(void *buf, int nbytes) { -- 1.8.3.2
| |