lkml.org 
[lkml]   [2013]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:perf/core] perf record: Remove advance_output function
    Commit-ID:  f34b9001f9a2f6fa41d3582fe515d194cc86bfb2
    Gitweb: http://git.kernel.org/tip/f34b9001f9a2f6fa41d3582fe515d194cc86bfb2
    Author: David Ahern <dsahern@gmail.com>
    AuthorDate: Wed, 6 Nov 2013 11:41:35 -0700
    Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
    CommitDate: Thu, 7 Nov 2013 10:43:15 -0300

    perf record: Remove advance_output function

    1 line function with only 1 user; might as well embed directly.

    Signed-off-by: David Ahern <dsahern@gmail.com>
    Suggested-by: Ingo Molnar <mingo@kernel.org>
    Acked-by: Ingo Molnar <mingo@kernel.org>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Ingo Molnar <mingo@kernel.org>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Cc: Namhyung Kim <namhyung.kim@lge.com>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Cc: Stephane Eranian <eranian@google.com>
    Link: http://lkml.kernel.org/r/1383763297-27066-3-git-send-email-dsahern@gmail.com
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/builtin-record.c | 7 +------
    1 file changed, 1 insertion(+), 6 deletions(-)

    diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
    index 2932069..19c4db6 100644
    --- a/tools/perf/builtin-record.c
    +++ b/tools/perf/builtin-record.c
    @@ -77,11 +77,6 @@ struct perf_record {
    off_t post_processing_offset;
    };

    -static void advance_output(struct perf_record *rec, size_t size)
    -{
    - rec->bytes_written += size;
    -}
    -
    static int write_output(struct perf_record *rec, void *buf, size_t size)
    {
    struct perf_data_file *file = &rec->file;
    @@ -461,7 +456,7 @@ static int __cmd_record(struct perf_record *rec, int argc, const char **argv)
    pr_err("Couldn't record tracing data.\n");
    goto out_delete_session;
    }
    - advance_output(rec, err);
    + rec->bytes_written += err;
    }
    }


    \
     
     \ /
      Last update: 2013-11-07 17:01    [W:3.062 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site