Messages in this thread | | | Date | Thu, 7 Nov 2013 10:24:47 -0500 (EST) | From | Alan Stern <> | Subject | Re: [PATCH v2] usb: gadget: f_mass_storage: call try_to_freeze only when its safe |
| |
On Thu, 7 Nov 2013, George Cherian wrote:
> Call try_to_freeze() in sleep_thread() only when its safe to sleep. > do_read() and do_write() calls sleep_thread with lock held. > Make sure these wont call try_to_freeze() by passing can_freeze flag > to sleep_thread. > > Calling try_to_freeze() with a lock hold was done since day one in > f_mass_storage but since commit 0f9548ca1 ("lockdep: check that no > locks held at freeze time") lockdep complains about it.
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Although I would have preferred it if you spelled "it's" and "won't" with apostrophes in the first paragraph. Without the apostrophes, "its" is a possessive pronoun (meaning "something belonging to it") and "wont" is a noun (meaning "habit").
Alan Stern
| |