Messages in this thread | | | Date | Thu, 07 Nov 2013 14:49:51 +0100 | From | Sebastian Andrzej Siewior <> | Subject | Re: [PATCH] usb: gadget: f_mass_storage: call try_to_freeze only when its safe |
| |
On 11/07/2013 02:37 PM, George Cherian wrote: > Call try_to_freeze() in sleep_thread() only when its safe to sleep. > do_read() and do_write() calls sleep_thread with lock held. > Make sure these wont call try_to_freeze() by passing can_freeze flag > to sleep_thread.
Thank you. This is was Alan asked for and I forgot.
You could add
|Calling try_to_freeze() with a lock hold was done since day one in |f_mass_storage but since commit 0f9548ca1 ("lockdep: check that no |locks held at freeze time") lockdep complains about it.
so we have an explanation why it is suddenly a bad thing.
> Signed-off-by: George Cherian <george.cherian@ti.com>
Acked-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Sebastian
| |