lkml.org 
[lkml]   [2013]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] usb: gadget: f_mass_storage: call try_to_freeze only when its safe
On 11/7/2013 7:19 PM, Sebastian Andrzej Siewior wrote:
> On 11/07/2013 02:37 PM, George Cherian wrote:
>> Call try_to_freeze() in sleep_thread() only when its safe to sleep.
>> do_read() and do_write() calls sleep_thread with lock held.
>> Make sure these wont call try_to_freeze() by passing can_freeze flag
>> to sleep_thread.
> Thank you. This is was Alan asked for and I forgot.
>
> You could add
>
> |Calling try_to_freeze() with a lock hold was done since day one in
> |f_mass_storage but since commit 0f9548ca1 ("lockdep: check that no
> |locks held at freeze time") lockdep complains about it.
>
> so we have an explanation why it is suddenly a bad thing.

okay will send v2 with commit log amend and your Acked-by
>
>> Signed-off-by: George Cherian <george.cherian@ti.com>
> Acked-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
>
> Sebastian


--
-George



\
 
 \ /
  Last update: 2013-11-07 15:21    [W:0.048 / U:0.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site