lkml.org 
[lkml]   [2013]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/5] OF: Clear detach flag on attach
Hello Pantelis,

On 05/11/13 21:03, ext Pantelis Antoniou wrote:
> On Nov 5, 2013, at 9:43 PM, Gerhard Sittig wrote:
>>> --- a/drivers/of/base.c
>>> +++ b/drivers/of/base.c
>>> @@ -1641,6 +1641,7 @@ int of_attach_node(struct device_node *np)
>>> np->allnext = of_allnodes;
>>> np->parent->child = np;
>>> of_allnodes = np;
>>> + of_node_clear_flag(np, OF_DETACHED);
>>> raw_spin_unlock_irqrestore(&devtree_lock, flags);
>>>
>>> of_add_proc_dt_entry(np);
>>
>> Does this add a call to a routine which only gets introduced in a
>> subsequent patch (2/5)? If so, it would break builds during the
>> series, and thus would hinder bisection.
>>
>
> You're right, I'll re-order on the next series.

Is it necessary at all now, after these fixes:
9e401275 of: fdt: fix memory initialization for expanded DT
0640332e of: Fix missing memory initialization on FDT unflattening
92d31610 of/fdt: Remove duplicate memory clearing on FDT unflattening

?

--
Best regards,
Alexander Sverdlin.


\
 
 \ /
  Last update: 2013-11-06 10:21    [W:0.097 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site