Messages in this thread | | | Date | Thu, 7 Nov 2013 12:55:42 +0800 | From | Shawn Guo <> | Subject | Re: [PATCH 1/1] cpufreq: cpufreq-cpu0: use the max voltage instead of voltage-tolerance |
| |
On Thu, Nov 07, 2013 at 03:32:09AM +0000, Rongjun Ying wrote: > I think my patch is better.
Well, unfortunately your patch is plainly wrong, because there are in-tree users of voltage-tolerance right now. How can you simply remove it from driver with ignoring these users?
$ git grep voltage-tolerance arch/arm/boot/dts arch/arm/boot/dts/am33xx.dtsi: voltage-tolerance = <2>; /* 2 percentage */ arch/arm/boot/dts/imx27.dtsi: voltage-tolerance = <5>; arch/arm/boot/dts/r8a73a4-ape6evm-reference.dts: voltage-tolerance = <1>; /* 1% */ arch/arm/boot/dts/r8a73a4-ape6evm.dts: voltage-tolerance = <1>; /* 1% */ arch/arm/boot/dts/sh73a0-kzm9g-reference.dts: voltage-tolerance = <1>; /* 1% */
Shawn
> All soc have a max work voltage. If regulator IC can't supply min voltage, > It can supply max voltage to soc. > As my patch, not need overwrite OPP in <board>.dts. > As your comment above, almost all board need overwrite OPP, unless the regulator > IC can supply all voltage ranges of SoC need.
| |