Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [trivial PATCH] module.h: Remove unnecessary semicolon | Date | Thu, 07 Nov 2013 12:32:50 +1030 |
| |
Joe Perches <joe@perches.com> writes: > This semicolon isn't necessary, remove it. > > Signed-off-by: Joe Perches <joe@perches.com>
This is a terrible description. Really bad.
First, it just repeats the subject, with more words.
Second, it gives me no indication that you've done a grep to make sure noone is abusing the macro, so I can't apply it without doing that check myself.
Please try again.
Rusty.
> --- > include/linux/module.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/module.h b/include/linux/module.h > index 05f2447..d1ad477 100644 > --- a/include/linux/module.h > +++ b/include/linux/module.h > @@ -454,7 +454,7 @@ int module_kallsyms_on_each_symbol(int (*fn)(void *, const char *, > > extern void __module_put_and_exit(struct module *mod, long code) > __attribute__((noreturn)); > -#define module_put_and_exit(code) __module_put_and_exit(THIS_MODULE, code); > +#define module_put_and_exit(code) __module_put_and_exit(THIS_MODULE, code) > > #ifdef CONFIG_MODULE_UNLOAD > unsigned long module_refcount(struct module *mod);
| |