lkml.org 
[lkml]   [2013]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 05/11] ARM: Introduce CPU_METHOD_OF_DECLARE() for cpu hotplug/smp
    Hey Stephen-

    Nit/suggestion below:

    On Fri, Nov 01, 2013 at 03:08:53PM -0700, Stephen Boyd wrote:
    [..]
    > diff --git a/arch/arm/include/asm/smp.h b/arch/arm/include/asm/smp.h
    > index a8cae71c..c27ec55 100644
    > --- a/arch/arm/include/asm/smp.h
    > +++ b/arch/arm/include/asm/smp.h
    > @@ -112,6 +112,15 @@ struct smp_operations {
    > #endif
    > };
    >
    > +struct of_cpu_method {
    > + const char *method;
    > + struct smp_operations *ops;
    > +};
    > +
    > +#define CPU_METHOD_OF_DECLARE(name, _method, _ops) \
    > + static const struct of_cpu_method __cpu_method_of_table_##name \
    > + __used __section(__cpu_method_of_table) \
    > + = { .method = _method, .ops = _ops }
    > /*
    > * set platform specific SMP operations
    > */
    > diff --git a/arch/arm/kernel/devtree.c b/arch/arm/kernel/devtree.c
    > index f35906b..71a8592 100644
    > --- a/arch/arm/kernel/devtree.c
    > +++ b/arch/arm/kernel/devtree.c
    > @@ -25,6 +25,7 @@
    > #include <asm/smp_plat.h>
    > #include <asm/mach/arch.h>
    > #include <asm/mach-types.h>
    > +#include <asm/smp.h>
    >
    > void __init early_init_dt_add_memory_arch(u64 base, u64 size)
    > {
    > @@ -63,6 +64,36 @@ void __init arm_dt_memblock_reserve(void)
    > }
    > }
    >
    > +#ifdef CONFIG_SMP
    > +extern struct of_cpu_method __cpu_method_of_table[];
    > +
    > +static const struct of_cpu_method __cpu_method_of_table_sentinel
    > + __used __section(__cpu_method_of_table_end);

    Having a sentinel allocated into the linked image makes a lot of sense
    in other cases (IRQCHIP/CLOCKSOURCE_OF_DECLARE, etc), where it's used to
    terminate an of_device_id table (as is expected by of_match_table and
    friends).

    In this case, however, you aren't building a match table, so having a
    sentinel allocated isn't necessary. I'd suggest bookending the table
    with a VMLINUX_SYMBOL(__cpu_method_of_table_end) instead.

    A whole 2 pointers worth of savings!

    --
    The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
    hosted by The Linux Foundation


    \
     
     \ /
      Last update: 2013-11-07 03:41    [W:4.147 / U:0.180 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site