lkml.org 
[lkml]   [2013]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 2/2] mm: allow to set overcommit ratio more precisely
On 11/06/2013 02:33 PM, Andrew Morton wrote:
> On Wed, 6 Nov 2013 03:42:20 -0500 (EST) Jerome Marchand <jmarchan@redhat.com> wrote:
>> That was my first version of this patch (actually "kbytes" to avoid
>> overflow).
>> Dave raised the issue that it silently breaks the user interface:
>> overcommit_ratio is zero while the system behaves differently.
>
> I don't understand that at all. We keep overcommit_ratio as-is, with
> the same default values and add a different way of altering it. That
> should be back-compatible?

Reading the old thread, I think my main point was that we shouldn't
output overcommit_ratio=0 when overcommit_bytes>0. We need to round up
for numbers less than 1 so that folks don't think overcommit_ratio is _off_.

I was really just trying to talk you in to cramming the extra precision
in to the _existing_ sysctl. :) I don't think bytes vs. ratio is really
that big of a deal.


\
 
 \ /
  Last update: 2013-11-07 01:41    [W:0.612 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site