Messages in this thread | | | Subject | Re: [PATCH v2 2/2] x86: add prefetching to do_csum | From | Joe Perches <> | Date | Wed, 06 Nov 2013 12:07:38 -0800 |
| |
On Wed, 2013-11-06 at 15:02 -0500, Neil Horman wrote: > On Wed, Nov 06, 2013 at 09:19:23AM -0800, Joe Perches wrote: [] > > __always_inline instead of inline > > static __always_inline void prefetch_lines(const void *addr, size_t len) > > { > > const void *end = addr + len; > > ... > > > > buff doesn't need a void * cast in prefetch_lines > > > Actually I take back what I said here, we do need the cast, not for a conversion > from unsigned char * to void *, but rather to discard the const qualifier > without making the compiler complain.
Not if the function is changed to const void * and end is also const void * as shown.
| |