lkml.org 
[lkml]   [2013]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/2] x86: add prefetching to do_csum
On Wed, Nov 06, 2013 at 10:23:10AM -0800, Eric Dumazet wrote:
> On Wed, 2013-11-06 at 10:54 -0500, Neil Horman wrote:
>
> > My guess was that the whole comment was made in reference to the fact that
> > checksum offload negated all these advantages. Thats not so true anymore, since
> > infiniband needs csum in software for ipoib.
> >
> > I'll fix this up and send a v3, but I'll give it a day in case there are more
> > comments first.
>
> Also please include netdev, I think people there are interested.
>
Sure, will do in the updated version

> I caught this message, but I usually cannot read lkml traffic.
>
> I wonder why you do not use (and/or change/tune) prefetch_range()
> instead of a local definition.
>
I wanted to look into this further, because I wasn't (yet) sure if it was a bug
or not, but from what I can see x86_64 doesn't define ARCH_HAS_PREFECTH. That
makes prefetch_range() a nop (I confirmed this via objdump). It seems like we
should either define ARCH_HAS_PREFETCH on x86_64, or we should remove the
#ifdef from prefetch_range
>
>
>


\
 
 \ /
  Last update: 2013-11-06 20:41    [W:0.142 / U:0.620 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site