Messages in this thread | | | From | "Gupta, Pekon" <> | Subject | RE: [PATCH -next] mtd: nand: omap: fix error return code in omap_nand_probe() | Date | Wed, 6 Nov 2013 18:06:25 +0000 |
| |
> From: Brian Norris [mailto:computersforpeace@gmail.com] > > On Thu, Oct 31, 2013 at 7:18 PM, Jingoo Han <jg1.han@samsung.com> > >> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > >> > >> Fix to return a negative error code from the error handling > >> case instead of 0, as done elsewhere in this function. > > > > Commit message is right? :-( > > It sounds OK by my reading. Unless you're having trouble parsing what > "as done elsewhere in this function" is being applied to. (IOW, is the > rest of the function returning a negative error code on the error > paths, or is it returning 0? Of course the answer is the former, but > it's possible to misread it.) If it helps, I can try to tweak the > wording a bit when applying this patch. > > Pekon, can I get an Acked-by? > Yes sure .. Sorry I was away from both mailbox and boards. Acked-by: Pekon Gupta <pekon@ti.com>
And thanks much Wei Yongjun for fixing this .
with regards, pekon
| |