lkml.org 
[lkml]   [2013]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: new asus fan driver
On Wed, Nov 06, 2013 at 12:55:56AM -0800, Greg Kroah-Hartman wrote:

> Matthew, please don't push drivers to the staging tree that have no
> problems on their own, and don't require work within them to get out of
> staging, as that doesn't help much, as I don't want to take code that
> has to wait for external things to happen before it can move out of
> staging.

I'm not willing to commit to supporting this code with the
virt_to_phys() hack in place, but I also don't want to block Felipe from
having an incentive to fix up the ACPI core so we can do this cleanly.
What I suggested was adding it to the asus-wmi driver and wrapping the
functionality with CONFIG_STAGING in order to indicate that there were
no promises that this feature would remain, and then giving Felipe a few
months to do the ACPI work. If it got done in a reasonable time then
we'd keep the code, and if not I'd drop it. I certainly didn't suggest
writing a separate driver, let alone putting it in staging.

--
Matthew Garrett | mjg59@srcf.ucam.org


\
 
 \ /
  Last update: 2013-11-06 16:01    [W:0.052 / U:1.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site