Messages in this thread | | | Subject | Re: [PATCH 09/10] dmatest: gather test results in the linked list | From | Andy Shevchenko <> | Date | Wed, 06 Nov 2013 16:13:41 +0200 |
| |
On Tue, 2013-11-05 at 11:58 -0800, Dan Williams wrote: > On Mon, Mar 4, 2013 at 1:09 AM, Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > The patch provides a storage for the test results in the linked list. The > > gathered data could be used after test is done. > > > > The new file 'results' represents gathered data of the in progress test. The > > messages collected are printed to the kernel log as well. > > > > Example of output: > > % cat /sys/kernel/debug/dmatest/results > > dma0chan0-copy0: #1: No errors with src_off=0x7bf dst_off=0x8ad len=0x3fea (0) > > > > The message format is unified across the different types of errors. A number in > > the parens represents additional information, e.g. error code, error counter, > > or status. > > > > Note that the buffer comparison is done in the old way, i.e. data is not > > collected and just printed out. > > > > I need to revert this to get my testing done as it just leaks memory > for no real benefit that I can see. Outside of making the log > messages have a uniform format I'm not seeing the case for this? I'll > revert and add a pr_fmt to make dmatest messages readily parseable.
The benefit of it is to access to the results asynchronously as many times as tester wants to.
Actually I wonder where you found memory leak. It keeps the result only for the last test run.
-- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy
| |