lkml.org 
[lkml]   [2013]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] thermal: Fix binding problem when there is thermal zone params
On 11/06/2013 01:29 PM, Zhang Rui wrote:
> On Fri, 2013-10-18 at 18:03 +0800, Wei Ni wrote:
>> @@ -247,7 +247,7 @@ static void bind_cdev(struct thermal_cooling_device *cdev)
>> if (!pos->tzp && !pos->ops->bind)
>> continue;
>>
>> - if (!pos->tzp && pos->ops->bind) {
>> + if (pos->ops->bind) {
>> ret = pos->ops->bind(pos, cdev);
>> if (ret)
>> print_bind_err_msg(pos, cdev, ret);
> IMO, we should also add
> + continue;
> after binding with pos->ops->bind(), to void binding via pos->tzp->tbp
> again, no?

Oh, yes, you are right. I will add it.

>
> thanks,
> rui
>> @@ -282,8 +282,8 @@ static void bind_tz(struct thermal_zone_device *tz)
>>
>> mutex_lock(&thermal_list_lock);
>>
>> - /* If there is no platform data, try to use ops->bind */
>> - if (!tzp && tz->ops->bind) {
>> + /* If there is ops->bind, try to use ops->bind */
>> + if (tz->ops->bind) {
>> list_for_each_entry(pos, &thermal_cdev_list, node) {
>> ret = tz->ops->bind(tz, pos);
>> if (ret)
>
>



\
 
 \ /
  Last update: 2013-11-06 07:41    [W:0.109 / U:0.472 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site