lkml.org 
[lkml]   [2013]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/9] GenWQE: Remove option to select name
From
Date
Hi Ryan,

Am Dienstag, den 05.11.2013, 08:55 +1100 schrieb Ryan Mallon:
> On 05/11/13 04:08, Frank Haverkamp wrote:
> > Selecting interface names via configuration option is obsolete.
>
> Don't do this. You are adding completely new code, so there is no reason
> to post a patch full of code that is known to be incorrect, followed by
> a set of patches fixing things. Just post the correct code to start
> with. This makes the git history cleaner, and makes the code easier to
> review.

Agreed.

> You can use tools like git interactive rebase to split your work into
> multiple patches. It should be quite easy for this because you mostly
> just want to break down things to the file level, so even:
>
> git reset --soft <your-first-commit>
>
> and then manually staging and commiting things from there would probably
> be enough. You can use git add --interactive to stage individual file
> hunks if you want to break things down further.

I have sent "Generic WorkQueue Engine (GenWQE) device driver (v6)" now
which hopefully is what you wanted.

Regards

Frank



\
 
 \ /
  Last update: 2013-11-05 10:21    [W:0.041 / U:1.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site