[lkml]   [2013]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] mm: create a separate slab for page->ptl allocation
On Wed, 6 Nov 2013 01:13:11 +0200 "Kirill A. Shutemov" <> wrote:

> > Really the function shouldn't exist in this case. It is __init so the
> > sin is not terrible, but can this be arranged?
> I would like to get rid of __ptlock_alloc()/__ptlock_free() too, but I
> don't see a way within C: we need to know sizeof(spinlock_t) on
> preprocessor stage.
> We can have a hack on kbuild level: write small helper program to find out
> sizeof(spinlock_t) before start building and turn it into define.
> But it's overkill from my POV. And cross-compilation will be a fun.

Yes, it doesn't seem worth the fuss. The compiler will remove all this
code anyway, so for example ptlock_cache_init() becomes an empty function.

 \ /
  Last update: 2013-11-06 02:21    [W:0.091 / U:0.656 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site