[lkml]   [2013]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH -next] mtd: nand: omap: fix error return code in omap_nand_probe()
On Thu, Oct 31, 2013 at 7:18 PM, Jingoo Han <> wrote:
> On Friday, November 01, 2013 9:16 AM, Wei Yongjun wrote:
>> From: Wei Yongjun <>
>> Fix to return a negative error code from the error handling
>> case instead of 0, as done elsewhere in this function.
> Commit message is right? :-(

It sounds OK by my reading. Unless you're having trouble parsing what
"as done elsewhere in this function" is being applied to. (IOW, is the
rest of the function returning a negative error code on the error
paths, or is it returning 0? Of course the answer is the former, but
it's possible to misread it.) If it helps, I can try to tweak the
wording a bit when applying this patch.

Pekon, can I get an Acked-by?


 \ /
  Last update: 2013-11-05 23:41    [W:0.049 / U:4.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site