Messages in this thread |  | | Date | Tue, 5 Nov 2013 20:43:10 +0100 | From | Gerhard Sittig <> | Subject | Re: [PATCH 1/5] OF: Clear detach flag on attach |
| |
On Tue, Nov 05, 2013 at 19:50 +0200, Pantelis Antoniou wrote: > > --- a/drivers/of/base.c > +++ b/drivers/of/base.c > @@ -1641,6 +1641,7 @@ int of_attach_node(struct device_node *np) > np->allnext = of_allnodes; > np->parent->child = np; > of_allnodes = np; > + of_node_clear_flag(np, OF_DETACHED); > raw_spin_unlock_irqrestore(&devtree_lock, flags); > > of_add_proc_dt_entry(np);
Does this add a call to a routine which only gets introduced in a subsequent patch (2/5)? If so, it would break builds during the series, and thus would hinder bisection.
virtually yours Gerhard Sittig -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr. 5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de
|  |