lkml.org 
[lkml]   [2013]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V3 06/11] perf record: Add an option to force per-cpu mmaps
PeterZ,

Can I have your Acked-by for this one? I guess now the goal is
achieved, no?

- Arnaldo

Em Tue, Nov 05, 2013 at 11:25:45AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Tue, Nov 05, 2013 at 02:30:24PM +0100, Jiri Olsa escreveu:
> > On Tue, Nov 05, 2013 at 03:09:30PM +0200, Adrian Hunter wrote:
> > > > right, I haven't considered the hundreds CPU machine.. I just
> > > > saw that it disables inherited events in my test ;-) maybe we
> > > > could mentioned that somewhere, because it's not clear
> > >
> > > How about this:
> > >
> > > From: Adrian Hunter <adrian.hunter@intel.com>
> > >
> > > By default, when tasks are specified (i.e. -p, -t
> > > or -u options) per-thread mmaps are created. Add
> > > an option to override that and force per-cpu mmaps.
> > >
> > > Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> >
> > seems ok, thanks
>
> Much better, but may I ask that the explanation in the man pages be
> present in the changeset commit as well? So that by just looking at 'git
> log' we can more readily get the whole picture, i.e. scalability versus
> wanting to have inherit.
>
> - Arnaldo
>
> > Acked-by: Jiri Olsa <jolsa@redhat.com>
> >
> > jirka


\
 
 \ /
  Last update: 2013-11-05 21:01    [W:0.080 / U:1.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site