lkml.org 
[lkml]   [2013]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 02/14] perf tools: Introduce struct add_entry_iter
    Date
    Hi Jiri,

    On Fri, 1 Nov 2013 13:07:35 +0100, Jiri Olsa wrote:
    > On Thu, Oct 31, 2013 at 03:56:04PM +0900, Namhyung Kim wrote:
    >> From: Namhyung Kim <namhyung.kim@lge.com>
    >
    > SNIP
    >
    >> +
    >> +static int
    >> +perf_evsel__add_entry(struct perf_evsel *evsel, struct addr_location *al,
    >> + struct perf_sample *sample, struct machine *machine,
    >> + struct add_entry_iter *iter)
    >> +{
    >> + int err;
    >> +
    >> + if ((sort__has_parent || symbol_conf.use_callchain) && sample->callchain) {
    >> + err = machine__resolve_callchain(machine, evsel, al->thread,
    >> + sample, &iter->parent, al,
    >> + iter->rep->max_stack);
    >> + if (err)
    >> + return err;
    >> + }
    >> +
    >> + err = iter->prepare_entry(iter, machine, evsel, al, sample);
    >> + if (err)
    >> + return err;
    >> +
    >> + err = iter->add_single_entry(iter, al);
    >> + if (err)
    >> + return err;
    >> +
    >> + while (iter->next_entry(iter, al)) {
    >> + err = iter->add_next_entry(iter, al);
    >> + if (err)
    >> + break;
    >> + }
    >> +
    >> + err = iter->finish_entry(iter, al);
    >> +
    >> + return err;
    >
    > return iter->finish_entry(iter, al); ?

    Right. Will fix in v3.

    Thanks,
    Namhyung


    \
     
     \ /
      Last update: 2013-11-05 08:41    [W:2.424 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site