Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [PATCH 02/14] perf tools: Introduce struct add_entry_iter | Date | Tue, 05 Nov 2013 16:16:40 +0900 |
| |
On Fri, 1 Nov 2013 13:09:09 +0100, Jiri Olsa wrote: > On Thu, Oct 31, 2013 at 03:56:04PM +0900, Namhyung Kim wrote: >> From: Namhyung Kim <namhyung.kim@lge.com> > > SNIP > >> +} >> + >> +static int >> +iter_add_next_nop_entry(struct add_entry_iter *iter __maybe_unused, >> + struct addr_location *al __maybe_unused) >> +{ >> + return 0; >> +} >> + >> +static int >> +iter_prepare_mem_entry(struct add_entry_iter *iter, struct machine *machine, >> + struct perf_evsel *evsel, struct addr_location *al, >> + struct perf_sample *sample) >> +{ >> + union perf_event *event = iter->priv; >> + struct mem_info *mi; >> + u8 cpumode; >> + >> + BUG_ON(event == NULL); > > the priv does not get assigned.. 'perf mem rep' aborts > > [jolsa@krava perf]$ ./perf mem rep --stdio > Aborted > perf: builtin-report.c:120: iter_prepare_mem_entry: Assertion `!(event == ((void *)0))' failed.
Argh... forgot to set it for mem entries after code refactoring, sorry. :-/ Will fix in v3.
Thanks, Namhyung
| |