[lkml]   [2013]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v4 2/4] perf stat: add event unit and scale support

One thing I realized while testing is that we cannot simply add the
unit printout like that.
This may break all the scripts people may have written to parse the
output of perf stat.
I think we need to make the display of the unit optional. If I do:
$ perf stat -e cycles ls

The output should remain as it was before and not show:
$ perf stat -e cycles ls
22782847475 ? cycles

So I think we need a --show-unit option. It would be off by default.
Of course doing this causes a mess with the current code because
of all the various printf() in builtin-stat.c but I think it is better for
the end user.

Any opinion?

On Mon, Nov 4, 2013 at 3:51 PM, Jiri Olsa <> wrote:
> On Mon, Nov 04, 2013 at 03:47:53PM +0100, Stephane Eranian wrote:
>> Jiri,
>> Thanks for the patch. I tested it and it works fine.
>> I will merge it with my "unit and scale" and add
>> your Signed-off-by. Is that okay with you?
> sure, np
> jirka

 \ /
  Last update: 2013-11-05 14:41    [W:0.061 / U:7.516 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site