lkml.org 
[lkml]   [2013]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V3 06/11] perf record: Add an option to force per-cpu mmaps
On Tue, Nov 05, 2013 at 03:09:30PM +0200, Adrian Hunter wrote:

SNIP

> >> Another advantage of per-thread mmaps is that you do not
> >> need to sample time (nor cpu), because the events are recorded
> >> in order.
> >>
> >> I was adding a feature. Users can choose per-cpu mmaps if
> >> they want.
> >
> > right, I haven't considered the hundreds CPU machine.. I just
> > saw that it disables inherited events in my test ;-) maybe we
> > could mentioned that somewhere, because it's not clear
>
> How about this:
>
> From: Adrian Hunter <adrian.hunter@intel.com>
>
> By default, when tasks are specified (i.e. -p, -t
> or -u options) per-thread mmaps are created. Add
> an option to override that and force per-cpu mmaps.
>
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>

seems ok, thanks

Acked-by: Jiri Olsa <jolsa@redhat.com>

jirka


\
 
 \ /
  Last update: 2013-11-05 14:41    [W:0.069 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site