Messages in this thread Patch in this message |  | | Subject | Re: [PATCH -next] get_maintainer: Improve "Author:" rolestats | From | Joe Perches <> | Date | Mon, 04 Nov 2013 21:54:27 -0800 |
| |
On Tue, 2013-11-05 at 13:45 +0800, Chen Gang wrote: > If really as what I guess above (some patches no Signed-of-by), is there > a tool to check and find this issue in time?
scripts/checkpatch.pl bleats a message on missing sign-offs.
For instance:
$ cat cache.diff include/linux/cache.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/cache.h b/include/linux/cache.h index 4c57065..17e7e82 100644 --- a/include/linux/cache.h +++ b/include/linux/cache.h @@ -1,11 +1,11 @@ #ifndef __LINUX_CACHE_H #define __LINUX_CACHE_H -#include <linux/kernel.h> +#include <uapi/linux/kernel.h> #include <asm/cache.h> #ifndef L1_CACHE_ALIGN -#define L1_CACHE_ALIGN(x) ALIGN(x, L1_CACHE_BYTES) +#define L1_CACHE_ALIGN(x) __ALIGN_KERNEL(x, L1_CACHE_BYTES) #endif #ifndef SMP_CACHE_BYTES $ ./scripts/checkpatch.pl cache.diff ERROR: Missing Signed-off-by: line(s)
total: 1 errors, 0 warnings, 13 lines checked
cache.diff has style problems, please review.
If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.
|  |