lkml.org 
[lkml]   [2013]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RFC PATCH] thinkpad_acpi: Add support for controlling charge thresholds
Date
Julian Andres Klode <jak@jak-linux.org> writes:

>
> +TPACPI_HANDLE(battery, root, "\\_SB.PCI0.LPC.EC.HKEY",
> + "\\_SB.PCI0.LPCB.EC.HKEY", /* X121e, T430u */
> + "\\_SB.PCI0.LPCB.H_EC.HKEY", /* L430 */
> + "\\_SB.PCI0.LPCB.EC0.HKEY", /* Edge/S series */
> + );
> +

Isn't this just the full patch to the existing "hkey_handle" for those
models? Why not just use that handle, like e.g the rfkill driver does?

Supported models could probably be autodetected by checking whether the
methods exist?

> +static struct attribute_group bat##_BAT##_attribute_group = { \
> + .name = "BAT" #_BAT, \
> + .attrs = bat##_BAT##_attributes \
> +};

Are these names guaranteed to match the ACPI battery device(s)?

> +DEFINE_BATTERY(0);
> +DEFINE_BATTERY(1);

Are there always two batteries?



Bjørn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2013-11-05 11:21    [W:0.054 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site