Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [PATCH 10/13] tracing/uprobes: Fetch args before reserving a ring buffer | Date | Tue, 05 Nov 2013 10:17:42 +0900 |
| |
On Mon, 4 Nov 2013 15:38:13 +0100, Oleg Nesterov wrote: > On 11/04, Namhyung Kim wrote: >> >> On Sun, 3 Nov 2013 21:20:37 +0100, Oleg Nesterov wrote: >> > >> > But. Perhaps it makes sense to at least add a couple of trivial >> > helpers in 10/13? Something like arg_buf_get/put/init, just to >> > simplify the potential changes. >> >> Good idea. How about something like below? > > Thanks, I agree with any implementation ;) > >> static DEFINE_MUTEX(uprobe_buffer_mutex); > > but see my previous email, afaics we don't need it.
I see. Probably checking the event_mutex is locked in front of the _enable/disable function would be enough.
Thanks, Namhyung
| |