Messages in this thread | | | Date | Tue, 5 Nov 2013 07:59:43 +1100 | From | Dave Chinner <> | Subject | Re: [PATCH V2] xfs: simplify kmem_{zone_}zalloc |
| |
On Mon, Nov 04, 2013 at 06:21:05PM +0800, Gu Zheng wrote: > Introduce flag KM_ZERO which is used to alloc zeroed entry, and convert > kmem_{zone_}zalloc to call kmem_{zone_}alloc() with KM_ZERO directly, > in order to avoid the setting to zero step. > And following Dave's suggestion, make kmem_{zone_}zalloc static inline > into kmem.h as they're now just a simple wrapper. > > V2: > Make kmem_{zone_}zalloc static inline into kmem.h as Dave suggested. > > Signed-off-by: Gu Zheng <guz.fnst@cn.fujitsu.com>
Looks good. It also results in a slight reduction in code size:
text data bss dec hex filename 792234 99018 632 891884 d9bec fs/xfs/xfs.o.orig 792090 99018 632 891740 d9b5c fs/xfs/xfs.o
Which means making it inline hasn't cost us anything at individual call sites.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Cheers,
Dave. -- Dave Chinner david@fromorbit.com
| |