lkml.org 
[lkml]   [2013]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 09/11] ARM: msm: Add SMP support for KPSSv2
On 11/01, Janakiram Sistla wrote:
> On 1 November 2013 15:08, Stephen Boyd <sboyd@codeaurora.org> wrote:
> > + err = -ENOMEM;
> > + goto err_map;
> > + }
> > +
> > + l2_saw_base = of_iomap(l2_node, 0);
> > + if (!l2_saw_base) {
> > + err = -ENOMEM;
> > + goto err_l2_map;
> > + }
> > +
> > + /* Turn on the BHS, turn off LDO Bypass and power down LDO */
> > + reg_val = 0x403f0001;
> >
> I think patch looks more nice if this hard coding is defined in terms of
> macros
>
> > + writel_relaxed(reg_val, reg + APC_PWR_GATE_CTL);
> > +
> > + /* complete the above write before the delay */
> > + mb();
> > + /* wait for the bhs to settle */
> > + udelay(1);
> > +
> > + /* Turn on BHS segments */
> > + reg_val |= 0x3f << 1;
> >
> same as above
>

Ok. I'll see what I can do.

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation


\
 
 \ /
  Last update: 2013-11-04 21:21    [W:0.134 / U:0.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site