lkml.org 
[lkml]   [2013]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Generic WorkQueue Engine (GenWQE) device driver (v4)
From
Date
Hi Greg,

Am Mittwoch, den 30.10.2013, 10:36 -0700 schrieb Greg KH:
> On Wed, Oct 30, 2013 at 10:32:58AM +0100, Frank Haverkamp wrote:
> > +/*
> > + * Module initialization and PCIe setup. Card health monitoring and
> > + * recovery functionality. Character device creation and deletion are
> > + * controlled from here.
> > + *
> > + * Please use the new sysfs interfaces to enable the VFs after PF
> > + * driver loading.
> > + *
> > + * Enable VFs:
> > + * sudo sh -c 'echo 15 > /sys/bus/pci/devices/0000\:1b\:00.0/sriov_numvfs'
> > + * or
> > + * sudo sh -c 'echo 15 > /sys/class/genwqe/genwqe0_card/device/sriov_numvfs'
> > + * Disable VFs:
> > + * Write a 0 into the same sysfs entries.
> > + */
>
> Put this documentation somewhere a user has a _chance_ of reading it.
> Digging it out of code comments is not ok. Why isn't this in the ABI
> file for the sysfs files?
>
> thanks,
>
> greg k-h
>

True. There was other stuff I moved/deleted now too.

Regards

Frank





\
 
 \ /
  Last update: 2013-11-04 17:41    [W:0.171 / U:0.616 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site