Messages in this thread |  | | Subject | Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver (v4) | From | Frank Haverkamp <> | Date | Mon, 04 Nov 2013 17:19:51 +0100 |
| |
Am Donnerstag, den 31.10.2013, 07:38 +1100 schrieb Ryan Mallon: > On 31/10/13 04:35, Greg KH wrote: > > > On Wed, Oct 30, 2013 at 10:32:58AM +0100, Frank Haverkamp wrote: > >> +if GENWQE > >> + > >> +config GENWQE_DEVNAME > >> + string "Name for sysfs and device nodes" > >> + default "genwqe" > >> + help > >> + Select alternate name for sysfs and device nodes. > > > > Don't let the user pick this, it's up to the driver to set this once and > > then live with it. > > > > And, from what I can tell in the driver, this help text is wrong (there > > are no device nodes with this name in it, right?) > > > The indentation is also messed up here. Kconfig should use hard tabs, with > two additional spaces for the help text. This has mixed tabs and spaces > between lines. >
Ok. Removed it anyways.
> ~Ryan > >
Regards
Frank
|  |