Messages in this thread |  | | Date | Mon, 4 Nov 2013 17:09:14 +0100 | From | Oleg Nesterov <> | Subject | Re: [PATCH 11/13] tracing/kprobes: Add priv argument to fetch functions |
| |
See my replies to 0/13. Lets assume that you agree that get_user_vaddr() doesn't need tu->inode.
On 10/29, Namhyung Kim wrote: > > This argument is for passing private data structure to each fetch > function and will be used by uprobes.
In this case, why do we need this "void *priv"? It actually becomes "bool need_addr_translation".
Can't we avoid it? Can't we just add FETCH_MTD_memory_notranslate ? kprobes should use the same methods for FETCH_MTD_memory*, uprobes should obviously adjust the addr in FETCH_MTD_memory.
Then (afaics) we need a single change in parse_probe_arg(),
- dprm->fetch = t->fetch[FETCH_MTD_memory]; + dprm->fetch = t->fetch[FETCH_MTD_memory_notranslate];
Yes, this will blow *probes_fetch_type_table[], but looks simpler.
And. This way it would be simple to teach parse_probe_arg('@') to use _notranslate, say, "@=addr" or whatever.
Oleg.
|  |