lkml.org 
[lkml]   [2013]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] pinctrl: remove minor dead code
From
On Tue, Oct 29, 2013 at 4:50 AM, Michael Opdenacker
<michael.opdenacker@free-electrons.com> wrote:

> This removes a test whether the 'desc' variable is NULL.
> This possibility has already been eliminated by the
> below test earlier in the loop:
>
> if (desc == NULL) {
> dev_warn(pctldev->dev,
> "could not get pin desc for pin %d\n",
> pins[i]);
> continue;
> }
>
> Found with Coverity: CID #1090078
>
> Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>

Pretty cool find!

Patch applied.

Yours,
Linus Walleij


\
 
 \ /
  Last update: 2013-11-04 13:21    [W:0.168 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site