lkml.org 
[lkml]   [2013]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:perf/core] perf completion: Introduce a layer of indirection
    Commit-ID:  2cf025e69543f5f4aa68e8549d60680515fef5ad
    Gitweb: http://git.kernel.org/tip/2cf025e69543f5f4aa68e8549d60680515fef5ad
    Author: Ramkumar Ramachandra <artagnon@gmail.com>
    AuthorDate: Sun, 17 Nov 2013 21:43:23 +0530
    Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
    CommitDate: Wed, 27 Nov 2013 14:58:35 -0300

    perf completion: Introduce a layer of indirection

    Define the variables cur, words, cword, and prev outside the main
    completion function so that we have a chance to override it when we
    introduce zsh support.

    Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
    Cc: Ingo Molnar <mingo@kernel.org>
    Link: http://lkml.kernel.org/r/1384704807-15779-2-git-send-email-artagnon@gmail.com
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/bash_completion | 17 +++++++++++------
    1 file changed, 11 insertions(+), 6 deletions(-)

    diff --git a/tools/perf/bash_completion b/tools/perf/bash_completion
    index 62e157db..3efdc84 100644
    --- a/tools/perf/bash_completion
    +++ b/tools/perf/bash_completion
    @@ -89,15 +89,12 @@ __ltrim_colon_completions()
    fi
    }

    -type perf &>/dev/null &&
    -_perf()
    +__perf_main ()
    {
    - local cur words cword prev cmd
    -
    - COMPREPLY=()
    - _get_comp_words_by_ref -n =: cur words cword prev
    + local cmd

    cmd=${words[0]}
    + COMPREPLY=()

    # List perf subcommands or long options
    if [ $cword -eq 1 ]; then
    @@ -120,6 +117,14 @@ _perf()
    opts=$($cmd $subcmd --list-opts)
    COMPREPLY=( $( compgen -W '$opts' -- "$cur" ) )
    fi
    +}
    +
    +type perf &>/dev/null &&
    +_perf()
    +{
    + local cur words cword prev
    + _get_comp_words_by_ref -n =: cur words cword prev
    + __perf_main
    } &&

    complete -o bashdefault -o default -o nospace -F _perf perf 2>/dev/null \

    \
     
     \ /
      Last update: 2013-11-30 14:41    [W:2.129 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site