lkml.org 
[lkml]   [2013]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: HID: kye: Add report fixup for Genius Manticore Keyboard

> Commit: 4a2c94c9b6c03af61b04993340bd9559e2277de4
> Author: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> AuthorDate: Wed Nov 20 09:49:41 2013 -0500
> Committer: Jiri Kosina <jkosina@suse.cz>
> CommitDate: Thu Nov 21 10:28:58 2013 +0100
>
> HID: kye: Add report fixup for Genius Manticore Keyboard
>
> Genius Manticore Keyboard presents the same problem in its report
> descriptors than Genius Gila Gaming Mouse and Genius Imperator Keyboard.
> Use the same fixup.

..

> diff --git a/drivers/hid/hid-kye.c b/drivers/hid/hid-kye.c
> index 7384512..35a4f9c 100644
> --- a/drivers/hid/hid-kye.c
> +++ b/drivers/hid/hid-kye.c
> @@ -341,6 +341,9 @@ static __u8 *kye_report_fixup(struct hid_device *hdev, __u8 *rdesc,
> case USB_DEVICE_ID_GENIUS_GX_IMPERATOR:
> rdesc = kye_consumer_control_fixup(hdev, rdesc, rsize, 83,
> "Genius Gx Imperator Keyboard");
> + case USB_DEVICE_ID_GENIUS_MANTICORE:
> + rdesc = kye_consumer_control_fixup(hdev, rdesc, rsize, 104,
> + "Genius Manticore Keyboard");
> break;


Is the IMPERATOR case supposed to fall-through to MANTICORE here, or is there a missing break ?
The commit text describes using the same fixup, but has this alternative case.

Dave



\
 
 \ /
  Last update: 2013-11-30 23:01    [W:0.141 / U:1.924 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site