Messages in this thread | | | Date | Sun, 03 Nov 2013 23:18:22 +0100 | From | Daniel Borkmann <> | Subject | Re: [PATCH net] net: flow_dissector: fail on evil iph->ihl |
| |
On 11/01/2013 08:01 AM, Jason Wang wrote: > We don't validate iph->ihl which may lead a dead loop if we meet a IPIP > skb whose iph->ihl is zero. Fix this by failing immediately when iph->ihl > is evil (less than 5). > > This issue were introduced by commit ec5efe7946280d1e84603389a1030ccec0a767ae > (rps: support IPIP encapsulation). > > Cc: Eric Dumazet <edumazet@google.com> > Cc: Petr Matousek <pmatouse@redhat.com> > Cc: Michael S. Tsirkin <mst@redhat.com> > Cc: Daniel Borkmann <dborkman@redhat.com> > Signed-off-by: Jason Wang <jasowang@redhat.com>
Sorry, a bit late as I was offline last 4 days, but fwiw:
Acked-by: Daniel Borkmann <dborkman@redhat.com>
| |