Messages in this thread | | | Date | Sun, 3 Nov 2013 21:20:37 +0100 | From | Oleg Nesterov <> | Subject | Re: [PATCH 10/13] tracing/uprobes: Fetch args before reserving a ring buffer |
| |
On 11/01, Oleg Nesterov wrote: > > Ah, please ignore... handler_chain() is not self-serialized, so > tu->buffer needs locking/waiting too.
Still I have to admit that I strongly dislike this yet another (and imho strange) memory pool. However, I am not going to argue because I can't suggest something better right now.
But. Perhaps it makes sense to at least add a couple of trivial helpers in 10/13? Something like arg_buf_get/put/init, just to simplify the potential changes.
Also. I think we should not use this pool unconditionally but again, this is another improvement we can do later.
Oleg.
| |