lkml.org 
[lkml]   [2013]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 1/4] perf diff: color the Delta column
On Thu, Nov 28, 2013 at 10:54:25PM +0530, Ramkumar Ramachandra wrote:
> Jiri Olsa wrote:
> > these colors are not consistent with colors in baseline,
> > moreover all negative values are shown as red
> >
> > - please check get_percent_color function (used for baseline),
> > it checks the percentage against following values:
> >
> > #define MIN_GREEN 0.5
> > #define MIN_RED 5.0
>
> That was intentional. If you want colors that are consistent with the
> baseline, what do we do about [4/4], where wdiff numbers can be huge?
> (currently I use [green, red] for [positive, negative] there too)

you're, ratio and wdiff need special treatment..

but I expect delta to be have same colors as baseline
(regardless of the +-)

thanks,
jirka


\
 
 \ /
  Last update: 2013-11-29 15:01    [W:0.048 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site