lkml.org 
[lkml]   [2013]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Q: use vlan in container
Quoting Libo Chen (clbchenlibo.chen@huawei.com):
> Hello LXC experts,
>
> I meet a problem. When using vlan as network device in suse11 system container,
> I can not use halt to stop this container. It hung on "eth0 is still used from interfaces eth0" in cycle.
>
> The config file:
>
> lxc.network.type = vlan
> lxc.network.flags = up
> lxc.network.link = eth0
> lxc.network.name = eth0
> lxc.network.vlan.id = 1301
> lxc.network.ipv4 = 128.5.131.100/24
>
>
> The reason is in the shell command /sbin/ifdown, see below:
>
> ######################################################################
> # Shut down depending interfaces
> #
> # Check if there are interfaces which depend on this interface. If yes these
> # have to be shut down first.
> # For example these might be bonding or vlan interfaces. Note that we don't
> # catch all types of depending interfaces currently. See function
> # 'get_depending_ifaces' in file 'functions' for details.
> #
> test "$SCRIPTNAME" = ifdown && DEP_IFACES=`get_depending_ifaces $INTERFACE`
> if [ "$?" = 0 -a "$NODEPS" != yes ] ; then
> message "`printf " %-9s is still used from interfaces %s" \
> $INTERFACE "$DEP_IFACES"`"
> for DI in $DEP_IFACES; do

Should the proper fix be to fix this script so that it doesn't call
ifdown recursively if $DI = $INTERFACE ?

> ifdown $DI -o $OPTIONS
> done
>
> message "`printf " %-9s now going down itself" $INTERFACE`"
> # check if iface is (still) avaliable
> # [bonding master may go down itself
> # while the last slave gets removed]
> if ! is_iface_available $INTERFACE; then
> exit $R_SUCCESS
> fi
> fi
>
>
> $DEP_IFACES is also eth0 in this scene, so ifdown will call ifdown again and again.
>
> if we set lxc.network.name = eth1, it will be ok, so can we add a judgment to make
> lxc.network.link and lxc.network.name are not equal in lxc-start command.
>
> simple implement like:
>
> if [ lxc.network.type == vlan ] ; then
> if [ lxc.network.link == lxc.network.name ] ; then
> return false
> fi
> fi
>
>
> Is it reasonable? or any other way to achieve this?
>
>
>


\
 
 \ /
  Last update: 2013-11-29 06:21    [W:0.083 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site