lkml.org 
[lkml]   [2013]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ARM: asm: Configure caches as per the defconfig
On 11/27/2013 5:44 PM, Russell King - ARM Linux wrote:
> On Wed, Nov 27, 2013 at 05:24:04PM +0530, Amit Virdi wrote:
>> From: Amit VIRDI <Amit.VIRDI@st.com>
>>
>> In the current implementation of the decompression code, the caches are enabled
>> irrespective of their configuration in the deconfig. This makes setting the
>> ICACHE and DCACHE disable options from the menuconfig irrelevant. Change this
>> implementation to enable caches only if specified in the defconfig.
>
> NAK. These options are provided more for ARM Ltd's validation of CPUs
> rather than for users, and it's not supposed to be used with the
> decompressor.
>

It is perfectly true that these options are used only during CPU
validations and not in the end product. Still, it doesn't justify why
these options are not to be used with decompressor. Or alternately, why
would a user intend to disable a cache when it has been implemented
correctly and is stable? Without this change, the effect of disabling
cache is not reflected in entirety.

Regards
Amit Virdi


\
 
 \ /
  Last update: 2013-11-28 07:01    [W:0.053 / U:0.772 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site