lkml.org 
[lkml]   [2013]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] PCI: export MSI mode using attributes, not kobjects
    On Wed, Nov 27, 2013 at 10:46:52AM -0800, Greg Kroah-Hartman wrote:
    > From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    >
    > The PCI MSI sysfs code is a mess with kobjects for things that don't
    > really need to be kobjects. This patch creates attributes dynamically
    > for the MSI interrupts instead of using kobjects.
    >
    > Note, this removes a directory from the current MSI interrupt sysfs
    > code:
    >
    > old MSI kobjects:
    > pci_device
    > └── msi_irqs
    >    └── 40
    >    └── mode
    >
    > new MSI attributes:
    > pci_device
    > └── msi_irqs
    >    └── 40
    >
    > As there was only one file "mode" with the kobject model, the interrupt
    > number is now a file that returns the "mode" of the interrupt (msi vs.
    > msix).
    >
    > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    >
    > ---
    >
    > Neil, can you test this patch to see if irqbalance works as-is or not?
    >
    ACK, Testing with git-head irqbalance on F19 with this patch and it works fine.

    Thanks!
    Acked-by: Neil Horman <nhorman@tuxdriver.com>

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2013-11-29 04:41    [W:3.569 / U:0.720 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site