Messages in this thread |  | | Date | Fri, 29 Nov 2013 10:57:20 +0800 | From | Chen Gang <> | Subject | Re: [PATCH] arch: hexagon: kernel: hexagon_ksyms.c remove useless __hexagon_*i3() |
| |
On 11/29/2013 10:29 AM, Chen Gang wrote: > Only find "DECLARE_EXPORT(__hexagon_*i3)", no related implementations > and callers, so remove them, or will cause ld issue with allmodconfig, > the related error: > > LD init/built-in.o > arch/hexagon/kernel/built-in.o:(___ksymtab+__hexagon_umodsi3+0x0): undefined reference to `__hexagon_umodsi3' > arch/hexagon/kernel/built-in.o:(___ksymtab+__hexagon_udivsi3+0x0): undefined reference to `__hexagon_udivsi3' > arch/hexagon/kernel/built-in.o:(___ksymtab+__hexagon_modsi3+0x0): undefined reference to `__hexagon_modsi3' > arch/hexagon/kernel/built-in.o:(___ksymtab+__hexagon_divsi3+0x0): undefined reference to `__hexagon_divsi3' >
Oh, sorry, this patch need improved, we can not only remove them simply (although really no related callers and implementations), I will send patch v2 later when finish allmodconfig.
Thanks.
> > Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> > --- > arch/hexagon/kernel/hexagon_ksyms.c | 5 ----- > 1 files changed, 0 insertions(+), 5 deletions(-) > > diff --git a/arch/hexagon/kernel/hexagon_ksyms.c b/arch/hexagon/kernel/hexagon_ksyms.c > index 32b1379..1257c85 100644 > --- a/arch/hexagon/kernel/hexagon_ksyms.c > +++ b/arch/hexagon/kernel/hexagon_ksyms.c > @@ -33,8 +33,3 @@ EXPORT_SYMBOL(memset); > > /* Symbols found in libgcc that assorted kernel modules need */ > DECLARE_EXPORT(__hexagon_memcpy_likely_aligned_min32bytes_mult8bytes); > - > -DECLARE_EXPORT(__hexagon_divsi3); > -DECLARE_EXPORT(__hexagon_modsi3); > -DECLARE_EXPORT(__hexagon_udivsi3); > -DECLARE_EXPORT(__hexagon_umodsi3); >
-- Chen Gang
|  |