[lkml]   [2013]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 3/3] usb: chipidea: hw_phymode_configure moved before ci_usb_phy_init
Hi Chris,

On Fri, Nov 29, 2013 at 12:08 AM, Chris Ruehl <> wrote:
> hw_phymode_configure configures the PORTSC registers and allow the
> following phy_inits to operate on the right parameters. This fix a problem
> where the UPLI (ISP1504) could not detected, because the Viewport was not
> available and returns 0's only.
> Signed-off-by: Chris Ruehl <>

I have already fixed this issue. It is in mainline now:

commit 03779f05be6dfc48de99763f6c845a003e1e40f3
Author: Fabio Estevam <>
Date: Wed Aug 14 12:43:56 2013 +0300

usb: chipidea: move hw_phymode_configure() into probe

Currently hw_phymode_configure() is located inside hw_device_reset(), which
only called by chipidea udc driver.

When operating in host mode, we also need to call hw_phymode_configure() in
order to properly configure the PHY mode, so move this function into probe.

After this change, USB Host1 port on mx53qsb board is functional.

Signed-off-by: Fabio Estevam <>
Tested-by: Arnaud Patard <>
Reviewed-by: Peter Chen <>
Signed-off-by: Alexander Shishkin <>
Signed-off-by: Greg Kroah-Hartman <>


Fabio Estevam

 \ /
  Last update: 2013-11-29 04:01    [W:0.047 / U:6.924 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site