[lkml]   [2013]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] genetlink: Fix uninitialized variable in genl_validate_assign_mc_groups()
From: Geert Uytterhoeven <>
Date: Sat, 23 Nov 2013 13:01:50 +0100

> net/netlink/genetlink.c: In function ‘genl_validate_assign_mc_groups’:
> net/netlink/genetlink.c:217: warning: ‘err’ may be used uninitialized in this
> function
> Commit 2a94fe48f32ccf7321450a2cc07f2b724a444e5b ("genetlink: make multicast
> groups const, prevent abuse") split genl_register_mc_group() in multiple
> functions, but dropped the initialization of err.
> Initialize err to zero to fix this.
> Signed-off-by: Geert Uytterhoeven <>
> ---
> Question: Is the for_each_net_rcu() loop in genl_validate_assign_mc_groups()
> guaranteed to loop at least once?
> If yes, this is a false positive.

Applied, but yes it's a false positive. There is always &init_net so the
loop always iterates at least once.
 \ /
  Last update: 2013-11-29 00:41    [W:0.024 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site