Messages in this thread |  | | From | Ramkumar Ramachandra <> | Date | Thu, 28 Nov 2013 22:54:25 +0530 | Subject | Re: [PATCH v3 1/4] perf diff: color the Delta column |
| |
Jiri Olsa wrote: > these colors are not consistent with colors in baseline, > moreover all negative values are shown as red > > - please check get_percent_color function (used for baseline), > it checks the percentage against following values: > > #define MIN_GREEN 0.5 > #define MIN_RED 5.0
That was intentional. If you want colors that are consistent with the baseline, what do we do about [4/4], where wdiff numbers can be huge? (currently I use [green, red] for [positive, negative] there too)
|  |