Messages in this thread | | | Date | Thu, 28 Nov 2013 09:03:45 -0700 | From | David Ahern <> | Subject | Re: [PATCHv3 3/7] perf tools: Fine tune readn function |
| |
On 11/28/13, 8:43 AM, Jiri Olsa wrote:
> - if (ret <= 0) > + if ((ret <= 0) && (errno != EINTR)) > return ret;
I think you want: if (ret < 0 && errno == EINTR) continue;
if (ret <= 0) return ret;
You certainly do not want ret < 0 here: ;-)
> > - n -= ret; > - buf += ret; > + left -= ret; > + buf += ret; > } > > - return buf - buf_start; > + BUG_ON((size_t)(buf - buf_start) != n); > + return n; > } > > size_t hex_width(u64 v) >
| |