[lkml]   [2013]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] sched: Remove PREEMPT_NEED_RESCHED from generic code
On 11/28/2013 02:26 PM, Peter Zijlstra wrote:
> Subject: sched: Remove PREEMPT_NEED_RESCHED from generic code
> While hunting a preemption issue with Alexander, Ben noticed that the
> currently generic PREEMPT_NEED_RESCHED stuff is horribly broken for
> load-store architectures.
> We currently rely on the IPI to fold TIF_NEED_RESCHED into
> PREEMPT_NEED_RESCHED, but when this IPI lands while we already have
> a load for the preempt-count but before the store, the store will erase
> The current preempt-count only works on load-store archs because
> interrupts are assumed to be completely balanced wrt their preempt_count
> fiddling; the previous preempt_count load will match the preempt_count
> state after the interrupt and therefore nothing gets lost.
> This patch removes the PREEMPT_NEED_RESCHED usage from generic code and
> pushes it into x86 arch code; the generic code goes back to relying on
> Boot tested on x86_64 and compile tested on ppc64.
> Reported-by: Alexander Graf <>
> Reported-by: Benjamin Herrenschmidt <>
> Signed-off-by: Peter Zijlstra <>

Fixes the issue for me.

Tested-by: Alexander Graf <>


 \ /
  Last update: 2013-11-28 16:41    [W:0.180 / U:5.756 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site